Fix Overlay when not preserving truth particles #2
Conversation
| @@ -21,7 +21,7 @@ SET( ${PROJECT_NAME}_VERSION_PATCH 0 ) | |||
| FIND_PACKAGE( ILCUTIL REQUIRED COMPONENTS ILCSOFT_CMAKE_MODULES ) | |||
|
|
|||
| # load default settings from ILCSOFT_CMAKE_MODULES | |||
| INCLUDE( ilcsoft_default_settings ) | |||
| #INCLUDE( ilcsoft_default_settings ) | |||
There was a problem hiding this comment.
Quick question for whoever has time. I always have to comment this out when compiling this locally with other packages due to an otherwise multiply defined unistall make target, although I seem to see a protection against this in the main make files included, but apparently it's not working well. Anyone else having these problems?
I can of course revert this change for the PR, since this should not be changed in the main mc branch.
There was a problem hiding this comment.
What do you mean when you write "compiling with other packages"?
Are you trying to merge the compilation of multiple components somehow?
If I remove the instruction above, cmake reports an error (Unknown CMake command "ADD_SHARED_LIBRARY")
There was a problem hiding this comment.
Hi @pandreetto , I've posted here the instructions to reproduce the problem:
MuonColliderSoft/LCTuple#4
(it happens for all packages)
This PR correctly resets the links to the original truth particles when merging the overlay tracker hit collections from the BIB to the main collision event. The current setup woul keep the pointer to a value that becomes invalid and causes segmentation violation if tried to be used (and no way to say that it's invalid).
In the process, this PR also ensures the proper
Overlayflag in simulated tracker hits is correctly set.BEGINRELEASENOTES
ENDRELEASENOTES